Repository navigation
fix(experimental-deploy): make experimental deploy stack-aware - #2162
Merged
Merged
Conversation
martin-helmich
force-pushed
the
fix/add-stack-id-experimental-deploy
branch
from
October 27, 2026 07:44
6577006 to
96753ea
Compare
Upgrade @mittwald/container-deploy to v2. The registry is deployed into a dedicated stack per project, and each application into its own stack named after the service. Existing services are kept in the stack they already live in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
…ntainer-deploy Default the service name to the name of the current directory instead of `app-<project-id>`, and default the image name and domain prefix to the service name, so that deployments from different directories no longer overwrite each other. Describe the whole command in its help text. Bump @mittwald/container-deploy to 2.0.1, whose setupProjectRegistry recovers from partially set up registries, and use its exported registry service name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
Member
|
Verified by manual testing. Works, apart from mittwald/container-deploy#27 and mittwald/container-deploy#28, both of which can be fixed independently. |
martin-helmich
added a commit
that referenced
this pull request
Oct 30, 2026
Adds a rule to `CLAUDE.md`: commands under `src/commands/experimental/` may change incompatibly (renamed or removed flags, changed defaults or behaviour) without being treated as breaking changes, so commits and PR titles for them are not marked as breaking (no `!`, no `BREAKING CHANGE` footer). Came up in #2162, which changes the defaults of `mw experimental deploy`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
mw experimental deploystack-aware, based on@mittwald/container-deployv2, which requires explicit stacks for the registry and the application (mittwald/container-deploy#22, plus mittwald/container-deploy#26 for recovering partially set up registries).Stack layout
project-registryservice already exists in some other stack (e.g. the default stack, where v1 put it), it is used where it is.The interim
--stack-id,--registry-stack-idand--application-stack-idflags from earlier commits on this branch are removed again; the command determines the stacks itself.Breaking changes to defaults
To make independent deployments in the same project possible, the following defaults change (acceptable for an experimental command):
--service-namedefaults to the name of the current directory (lowercased, runs of other characters than letters and digits replaced by a dash), instead ofapp-<project-id>.--image-namedefaults to the service name, instead ofapp-image.--uri-prefixdefaults to the service name, instead ofwebapp.Previously, all deployments in a project shared one service, image and domain unless all three flags were set. Existing deployments made with the old defaults get a new service, stack, image and domain on their next run.
Other changes
@mittwald/container-deployto 2.0.1. ItssetupProjectRegistrynow brings the registry into the desired state from any state (missing service, ingress or registry record, mismatched credentials), and identifies the project registry by its URI instead of taking the first non-public registry.project-registryis rejected, since it is reserved for the registry.Related: #2173 (redeploys clear the app's volume mounts since container-deploy v2), which is not addressed here.
🤖 Generated with Claude Code