Accumulate CPU half-precision sums in float32#3488
Open
sofinvalery wants to merge 1 commit intoml-explore:mainfrom
Open
Accumulate CPU half-precision sums in float32#3488sofinvalery wants to merge 1 commit intoml-explore:mainfrom
sofinvalery wants to merge 1 commit intoml-explore:mainfrom
Conversation
6aee023 to
10188e2
Compare
Author
|
Made it inline. Feels cleaner. |
zcbenz
requested changes
May 6, 2026
Collaborator
zcbenz
left a comment
There was a problem hiding this comment.
Allocating a new array would have heavy performance penalty, the correct way would be refactoring strided_reduce/contiguous_reduce to accumulate in float32 rather than the output type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Accumulate CPU float16 and bfloat16 sum reductions in float32, while preserving the output dtype. This fixes precision loss in ops that use sum().
Fixes #3326.
Checklist
Put an
xin the boxes that apply.