Repository navigation
Conversation
The crate's Cargo.toml was generated on every invocation by a wrapper script that stamped the package version from the nearest git tag. Check the manifest in directly, with the current release version (0.10.0) as a literal, and call plain cargo at every call site: CI, the CTest cargo_test, and the Dockerfile test stage (which no longer needs the checkout's .git copied in just so the wrapper could read the tag). The crates.io smoke-test crate gets the same treatment: its checked-in manifest pins the current published release exactly, and the release smoke workflow rewrites that pin to the version under test. With the version a literal in the manifest, the committed Cargo.lock's root entry agrees with it in every checkout, and a release version bump is a deliberate manifest edit followed by a lock refresh.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.toml for the Rust binding was generated on every invocation by a shim stamping the version from git describe, so whether the committed Cargo.lock agreed with the manifest depended on which tags a checkout had; the v0.10.0 lock refresh needed special tag handling in CI.
This checks the manifest in with a literal version and deletes the shims and templates. Releases bump the version as an ordinary edit with the lock refresh. The smoke-test crate pins the published release it tests; release-smoke rewrites the pin to the version under test.