Read_raw_nirx#14055
Conversation
emma-bailey
requested review from
agramfort,
drammock and
larsoner
as code owners
for more information, see https://pre-commit.ci
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Style tests are failing, can you merge main into your branch? I recently made some style / typing fixes. Happy to help if you want!
| @@ -0,0 +1,31 @@ | |||
| # OptiPNG version 0.7.8 | |||
There was a problem hiding this comment.
This all looks like it shouldn't be in this PR?
There was a problem hiding this comment.
Based on the docs I found here which stated:
On Windows, unzip optipng.exe from the [optipng for Windows (http://prdownloads.sourceforge.net/optipng/optipng-0.7.8-win64.zip?download) archive into the doc/ folder. This step is optional for Windows users.
I just unzipped and this file was created. I can still remove it if you like!
There was a problem hiding this comment.
I synced main to my fork now ✅
There was a problem hiding this comment.
Yes please remove this directory (from the PR, you can keep your local copy if you want), these files shouldn't be committed
|
Can you add a The style CI is unhappy: https://github.com/mne-tools/mne-python/actions/runs/29415131134/job/87351243860?pr=14055 CircleCI don't worry about, I can get that to run once those are addressed ☝️ |
2 participants
What does this implement/fix?
Updating read_raw_nirx to accept the newer data format output from Aurora recording software. The main changes relate to the change from a *probeInfo.mat to a *probeInfo.json to store optode locations. Additional changes relate to the fact a .tri file was prevoiusly mandatory for Aurora data though this may not always be present i.e. for a resting-state fNIRS recording.
I implemented the code and tested the changes locally myself, Claude Sonnet 4.6 wrote the official test in test_nirx.py, prompted to base this on the previous test implemented for aurora_2021_9_6.