Skip to content

WIP: add type hints to mne/_fiff/ module - #14278

Open
drammock wants to merge 2 commits into
mne-tools:mainfrom
drammock:type_fiff
Open

WIP: add type hints to mne/_fiff/ module#14278
drammock wants to merge 2 commits into
mne-tools:mainfrom
drammock:type_fiff

Conversation

@drammock

@drammock drammock commented Sep 4, 2026

Copy link
Copy Markdown
Member

opening as draft PR so folks can take a look and tell me what I did wrong, before I move on to doing the remaining files in mne/_fiff/

@larsoner

larsoner commented Sep 4, 2026

Copy link
Copy Markdown
Member

I think any change to typing should carry a ty change that allowlists (or un-blocklists) the files if possible. I think at the end of the day we can lean on ty plus our existing unit tests (including the test_docstring_parameters to make sure things make sense and are correctly applied

@drammock

drammock commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

I think any change to typing should carry a ty change that allowlists (or un-blocklists) the files if possible.

Oops. Totally agree and meant to do that; had been locally running ty manually on the changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants