Repository navigation
Conversation
Member
|
I am not 100% sure I understand the consequences, but I think bad channels should probably be excluded in virtual channels |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While cleaning up this test, I noticed that bad data from a bridged channel leaks into its own repair via the virtual channel.
The merged PR #14287 excluded non-bridged bads from the interpolation, but the virtual channel is still built from all channels in the group, including ones marked bad (ll. 161ff in interpolate.py), which makes the current test fail:
FAILED mne/preprocessing/tests/test_interpolate.py::test_interpolate_bridged_electrodes_bads - AssertionError: assert np.float64(0.32628997413460664) < 0.001
TBD: