Repository navigation
BUG: Fix picks_artifact passed as exclude in regress_artifact - #14457
Merged
Merged
Conversation
DerAndereJohannes
force-pushed
the
regression_fix
branch
from
October 24, 2026 11:44
c49af1e to
b8c44d2
Compare
DerAndereJohannes
requested review from
agramfort,
drammock and
larsoner
as code owners
October 24, 2026 11:44
Contributor
|
Thanks @DerAndereJohannes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
There seems to have been a slipup in the regression code when you passed in already computed betas. The issue was that
picks_artifactwas passed positionally and actually ended up in theexcludevariable. To fix, I changed the buggy version for the same call as in the non-beta version.Additional information
I fixed the code myself and used
qwen3.8-flash-next-IQ3_Sto create the pytest. The test was manually reviewed and the before and after results were compared.