Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/dev/14458.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clear head shape points omit filter in :meth:`mne.coreg.Coregistration.set_info` when loading a new digitizer recording (:gh:`14420`), by `Badri Vishal Pandey`_.
1 change: 1 addition & 0 deletions doc/changes/names.inc
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
.. _Athish M: https://github.com/athishdresu
.. _Austin Hurst: https://github.com/a-hurst
.. _Ayushi Satodiya: https://github.com/ayuclan
.. _Badri Vishal Pandey: https://github.com/badrisatyam1-ctrl
.. _Baris Talar: https://github.com/baris-talar
.. _Basile Pinsard: https://github.com/bpinsard
.. _Beige Jerry Jin: https://github.com/BeiGeJin
Expand Down
1 change: 1 addition & 0 deletions mne/coreg.py
Original file line number Diff line number Diff line change
Expand Up @@ -1573,6 +1573,7 @@ def set_info(self, info):
"""
_validate_type(info, (Info, None), "info")
self._info = info
self._extra_points_filter = None
self._setup_digs()
return self

Expand Down
5 changes: 5 additions & 0 deletions mne/tests/test_coreg.py
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,11 @@ def test_coreg_fitting_invariants():
assert len(kept) <= prev_n_kept
prev_n_kept = len(kept)

# GH#14420: verify set_info clears omitted points filter
assert coreg._extra_points_filter is not None
coreg.set_info(info)
assert coreg._extra_points_filter is None

# fit_fiducials / fit_icp
for _ in range(5):
coreg.reset()
Expand Down
Loading