[WIP] user: GetExecUser: rewrite with parseUserArg, parseGroupArg#231
Draft
thaJeztah wants to merge 2 commits into
Draft
[WIP] user: GetExecUser: rewrite with parseUserArg, parseGroupArg#231thaJeztah wants to merge 2 commits into
thaJeztah wants to merge 2 commits into
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jun 30, 2026
Comment on lines
+396
to
+407
| // userArg is a parsed user argument for [GetExecUser]. | ||
| type userArg struct { | ||
| name string | ||
| uid int | ||
| isNumeric bool | ||
| } | ||
|
|
||
| // parseUserArg parses a user argument as either a user name or UID. | ||
| // | ||
| // If name is empty, parseUserArg returns "nil, nil" to indicate that no user | ||
| // argument was specified. | ||
| func parseUserArg(name string) (*userArg, error) { |
Member
Author
There was a problem hiding this comment.
Considering if we should move all these utilities to user_utils.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a similar approach as was applied to GetAdditionalGroups in 6eb9f15