Repository navigation
devices: reformat switch - #275
Merged
Merged
Conversation
Member
Author
|
Had this in a local branch, so let's open it as a PR 😅 |
kolyshkin
reviewed
Oct 27, 2026
Comment on lines
+102
to
+104
| ".lxc", ".lxd-mounts", // addresses https://github.com/lxc/lxd/issues/2825 | ||
| ".udev", // addresses https://github.com/opencontainers/runc/issues/2093 | ||
| ".incus-mounts": // addresses https://github.com/moby/sys/issues/260 |
Collaborator
There was a problem hiding this comment.
I'd drop the word "addresses", a bare link is fine.
Member
Author
There was a problem hiding this comment.
Yeah, I was debating as well; considered see XXX, but indeed just the URL would work.
I'll update and bring this one in.
kolyshkin
approved these changes
Oct 28, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Collaborator
There was a problem hiding this comment.
lgtm (and a nit -- feel free to either implement or ignore)
Wrap the cases, so that the corresponding comments can be put next to the item they relate to. updates 6b651fb Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
devices_format
branch
from
October 28, 2026 08:51
d0ac798 to
058c5e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the cases, so that the corresponding comments can be put next to the item they relate to.
updates 6b651fb