Repository navigation
Conversation
Member
Author
|
Forgot about the ignored hack we have in place. Fixed in 7381e90. Basically, only the required job needs to be there (and that should be |
Also have one job to gather and evaluate tests as needed
`expr` returns 1 (a failure) when the result is 0 which may lead to some failures even though nothing bad happenned (see testsuite.sh)
We will require only the gather-results job succeeding, so we can make things a little bit simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #399 hence the draft
This PR reworks the CI. The tests dependencies are now built once (per arch) and then reused as needed. There's also a new job at the end which gathers all the logs into one archive. It can also work as the
Requiredtarget.There are also some minor tweaks for the tests themselves like allowing to skip container creation and
$((...))instead ofexpr(the later had a side effect that wasn't anticipated).The best about this is probably the runtime which dropped from the original 100+ minutes to less than 40 minutes.