Skip to content

Disable server/discover probe timeout in in-memory tests to fix flaky Windows Debug CI hang (#1701) #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PranavSenthilnathan wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Disable server/discover probe timeout in in-memory tests to fix flaky Windows Debug CI hang (#1701) #1702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/ModelContextProtocol.Tests/ClientServerTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ public async ValueTask DisposeAsync()

protected async Task<McpClient> CreateMcpClientForServer(McpClientOptions? clientOptions = null)
{
clientOptions ??= new McpClientOptions();

// Disable the server/discover probe timeout to avoid CI slowness spuriously tripping it (issue #1701).
// Tests that need a specific probe timeout should create their own client instead of using this helper.
clientOptions.DiscoverProbeTimeout = Timeout.InfiniteTimeSpan;

@halter73 halter73 Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the 60 second TestConstant.DefaultTimeout timeout be better?

Suggested change
clientOptions.DiscoverProbeTimeout = Timeout.InfiniteTimeSpan;
clientOptions.DiscoverProbeTimeout = TestConstant.DefaultTimeout;


return await McpClient.CreateAsync(
new StreamClientTransport(
serverInput: _clientToServerPipe.Writer.AsStream(),
Expand Down