Close stdio input before waiting for server exit - #1838
Open
luisangelrod wants to merge 2 commits into
Open
Conversation
luisangelrod
force-pushed
the
fix/1836-graceful-stdio-shutdown
branch
from
August 31, 2026 11:51
b01139d to
620d49c
Compare
Contributor
Author
|
The current Windows Debug failure is unrelated to the stdio transport change. The two failed tests were:
The changed StdioClientTransportTests had no failures. Windows Release and both configurations on Ubuntu and macOS passed, and the focused stdio suite passes 216/216 locally. GitHub did not permit me to rerun the failed job from the fork, so a maintainer rerun may be needed. |
luisangelrod
marked this pull request as ready for review
August 31, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShutdownTimeoutValidation
dotnet test tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj --filter FullyQualifiedName~StdioClientTransportTests— 54 passed on each of net472, net8.0, net9.0, and net10.0 (216 total)dotnet build -c Release— succeeded with 0 warnings and 0 errorsShutdownTimeoutand pass with this change by observing a clean exit code of 0, without asserting wall-clock durationThe full test suite was also attempted locally. Unrelated environment dependencies involving the missing Node conformance helper and a localhost OAuth development certificate prevented a clean full-suite completion. One parallel task-cancellation test also failed during that run and passed when rerun in isolation.
Fixes #1836
Note
This pull request description and implementation were prepared with AI assistance.