Move basic-host and infra, to single sandboxed iframe architecture#718
Open
domfarolino wants to merge 1 commit into
Open
Move basic-host and infra, to single sandboxed iframe architecture#718domfarolino wants to merge 1 commit into
domfarolino wants to merge 1 commit into
Conversation
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-preact
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-solid
@modelcontextprotocol/server-basic-svelte
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-basic-vue
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-debug
@modelcontextprotocol/server-lazy-auth
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #717, implementing a single sandboxed iframe architecture via
basic-host, demonstrating a simpler version of what is now compliant per that PR.Motivation and Context
Updating
basic-hostin this way is not strictly necessary, but it demonstrates the simplest framing approach as first-class example in this repository, demoting the more complicated double sandboxed iframe approach and reserved sandbox messages.How Has This Been Tested?
All PDF server tests fail locally on
mainfor some reason. All screenshot tests failed too, for reasons mentioned in #717. Locally, I re-baselined all of the screenshot expectations and they all passed onmain, and I used those same re-baselined screenshot expectations when testing this PR, so everything should be good.Breaking Changes
No.
Types of changes
examples/, it seems documentation-only.Checklist
This PR contributes to #716.