chore: clear npm audit findings (15 -> 3)#725
Merged
Conversation
Non-breaking transitive updates via `npm audit fix`, plus a `sharp` major bump. Takes `npm audit` from 15 findings (2 critical, 7 high, 4 moderate, 2 low) to 3 moderate. Critical / high: - shell-quote 1.8.3 -> 1.9.0 (GHSA-w7jw-789q-3m8p, GHSA-395f-4hp3-45gv) - @babel/core 7.28.6 -> 7.29.7 (GHSA-4x5r-pxfx-6jf8) - sharp ^0.34.5 -> ^0.35.3 (GHSA-f88m-g3jw-g9cj; libvips CVE-2026-33327, CVE-2026-33328, CVE-2026-35590, CVE-2026-35591) - brace-expansion 1.1.16 / 2.1.2 (GHSA-3jxr-9vmj-r5cp) - fast-uri 3.1.4 (GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6) - hono 4.12.31 (8 advisories, incl. GHSA-88fw-hqm2-52qc, GHSA-hvrm-45r6-mjfj) - linkify-it 5.0.2 (GHSA-22p9-wv53-3rq4, GHSA-v245-v573-v5vm) Plus markdown-it 14.3.0, body-parser 2.3.0, type-is 2.1.0, undici 7.28.0 and vite 6.4.3. sharp is a devDependency used only by tests/e2e/generate-grid-screenshots, which is testIgnore'd unless GENERATE_SCREENSHOTS=1. The only breaking change in 0.35 is the Node floor moving to >=20.9.0, and CI runs Node 22; the API used (png / resize / toFile) is unchanged. The 3 remaining findings are all the same advisory (GHSA-frvp-7c67-39w9, path traversal in @hono/node-server's serve-static on Windows), reported once each for @hono/node-server, @modelcontextprotocol/sdk and @modelcontextprotocol/ext-apps. The fix is in @hono/node-server 2.0.5 but sdk 1.29.0 pins ^1.19.9, so the range cannot reach it; that needs an upstream bump. It is not reachable here either way — the SDK imports only getRequestListener and serve from that package, never serve-static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency-only security pass.
npm audit: 15 findings (2 critical, 7 high, 4 moderate, 2 low) -> 3 (0 critical, 0 high, 3 moderate).No source changes —
package.jsonmovessharponly; everything else is lockfile.Fixed
shell-quote@babel/coresharpbrace-expansionfast-urihonolinkify-itmarkdown-itbody-parsertype-is,undici,vite, other transitivesThe one non-trivial bump:
sharpsharpis a devDependency, used only bytests/e2e/generate-grid-screenshots.spec.ts, which istestIgnored unlessGENERATE_SCREENSHOTS=1. The only breaking change in 0.35 is the Node floor moving to>=20.9.0(CI runs Node 22), and the API used (png/resize/toFile) is unchanged.Remaining 3 moderate — upstream, and not reachable here
All three are the same advisory, GHSA-frvp-7c67-39w9 (path traversal in
@hono/node-server'sserve-staticon Windows), reported once each for@hono/node-server,@modelcontextprotocol/sdkand@modelcontextprotocol/ext-apps.@hono/node-server2.0.5, but@modelcontextprotocol/sdk@1.29.0(latest) pins^1.19.9, so the range cannot reach it. Needs an upstream SDK bump.npm audit fix --force"resolves" it by installing@modelcontextprotocol/sdk@1.24.3— a downgrade, not a fix.getRequestListenerandservefrom@hono/node-server(server/streamableHttp.js), neverserve-static. Anoverridesentry forcing v2 would put the streamable-HTTP transport at risk to silence a finding that cannot be triggered.Verification
npm test— 374 pass, 1 skip, 0 failnpm run build— cleannpm run prettier— cleanpackage-lock.jsoncontains onlyregistry.npmjs.orgURLs