Repository navigation
Align skills spec types and examples with the 2026-07-28 base schema - #157
Merged
Merged
Conversation
Deploying ext-skills with
|
| Latest commit: |
87cd708
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7f1f8d1.ext-skills.pages.dev |
| Branch Preview URL: | https://fix-156-request-params-types.ext-skills.pages.dev |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The proposal correctly follows repository governance and resolves the reported type inconsistencies.
0 open findings
What changed in this PR
Proposes a type-safe correction to the next Skills specification revision.
Changes:
- Adds named request-parameter interfaces requiring
_meta. - Aligns request inheritance with the base schema.
- Updates the referenced base-type list.
| File | Description |
|---|---|
docs/decisions.md |
Records the proposed schema-rendering correction and rationale. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
sambhav
changed the title
sambhav
force-pushed
the
fix/156-request-params-types
branch
from
October 11, 2026 12:40
daca994 to
163c540
Compare
sambhav
force-pushed
the
fix/156-request-params-types
branch
from
October 11, 2026 12:43
163c540 to
7457ff9
Compare
Named params for skills/get and resources/directory/read, cacheable directory results, *ResultResponse types, optional _meta on Skill, full _meta in request examples. Records the decision and re-anchors index.md. Fixes #156 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M8b7Vuu2jRefMhoZB3BrrX
sambhav
force-pushed
the
fix/156-request-params-types
branch
from
October 11, 2026 12:49
7457ff9 to
87cd708
Compare
olaservo
approved these changes
Oct 15, 2026
olaservo
added a commit
to olaservo/fast-agent
that referenced
this pull request
Oct 20, 2026
Follows modelcontextprotocol/ext-skills#157, which aligned the stable Skills page with the 2026-07-28 base schema. - SkillEntry accepts the optional `_meta` object. - resources/directory/read returns ReadResourceDirectoryResult, which extends CacheableResult, instead of ListResourcesResult. - Directory-read request types use the spec's names. - The connection test asserts the SDK stamps `params._meta` on skills/list, skills/get, and resources/directory/read. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 20, 2026
jancurn
pushed a commit
to apify/mcpc
that referenced
this pull request
Oct 20, 2026
[ext-skills#157](modelcontextprotocol/ext-skills#157) aligned the Skills spec with the 2026-07-28 base schema. For a client this means `ReadResourceDirectoryResult` extends `CacheableResult` (`ttlMs`, `cacheScope`), `Skill` has an optional `_meta`, and every request carries `_meta`. - `src/lib/types.ts`: type the caching hints on the directory read result and `_meta` on `Skill`. - `src/core/skills-schema.ts`: reject a skill entry whose `_meta` is not an object. - `test/e2e/server/index-v2.ts`: the test server returns the hints from `resources/directory/read`. - `test/unit/core/skills-schema.test.ts`: cover `_meta` pass-through and rejection, and the hints on directory reads. Request `_meta` needed no change: SDK 2.3.1 stamps it on every 2026-07-28 request. No changelog entry. `resources-directory-read` prints only the children, so the hints never reach a user, and entry `_meta` already passed through to `--json`. Verified with `tsc`, `eslint`, the skills unit tests, and `test/e2e/suites/basic/skills.test.sh` against the modern test server. Also tested with the live Cloudflare MCP server which serves skills. AI Disclosure: I used a coding agent to make these changes but have read and understand them. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
evalstate
added a commit
to evalstate/fast-agent
that referenced
this pull request
Oct 21, 2026
* Align MCP skills wire models with the 2026-10-15 spec revision Follows modelcontextprotocol/ext-skills#157, which aligned the stable Skills page with the 2026-07-28 base schema. - SkillEntry accepts the optional `_meta` object. - resources/directory/read returns ReadResourceDirectoryResult, which extends CacheableResult, instead of ListResourcesResult. - Directory-read request types use the spec's names. - The connection test asserts the SDK stamps `params._meta` on skills/list, skills/get, and resources/directory/read. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: use LATEST_PROTOCOL_VERSION for negotiated protocol version in skills test --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Shaun Smith <1936278+evalstate@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156.
Aligns
specification/stable/skills.mdxwith the2026-07-28base schema and records the decision.skills/get,resources/directory/read: named params interfaces, so_metais requiredReadResourceDirectoryResultextendsCacheableResult(breaking:ttlMs,cacheScoperequired)*ResultResponsetypes for each method; optional_metaonSkill_metaWhy this lands in stable
These are corrections to the published page rather than new design:
2026-07-28schema, andReadResourceDirectoryRequestfails to type-check against it (skills.mdx: ReadResourceDirectoryRequest does not type-check against the 2026-07-28 base schema #156)._metawas already required. The page's text says every request MUST include it. Only the types and examples disagreed.skills/listandskills/getcacheable so that every result type in the extension stays uniform with the base protocol;resources/directory/readwas the one it didn't catch. This is the only change that adds a requirement on servers, and it affects an optional method behinddirectoryRead: true.Corrections like these have landed on stable in place before (#139, and #147 after SEP-2640 went Final), so I've followed that route rather than opening a
draft/revision.index.mdexcerpt ranges are re-anchored to the new line numbers.Verification
All interfaces and all 16 examples type-check under
--strictagainst the base schema;docs:buildpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01M8b7Vuu2jRefMhoZB3BrrX
Generated by Claude Code