internal/jsonrpc2: contain handler panics and reply with an internal error - #1180
Open
ez-lbz wants to merge 1 commit into
Open
internal/jsonrpc2: contain handler panics and reply with an internal error#1180ez-lbz wants to merge 1 commit into
ez-lbz wants to merge 1 commit into
Conversation
…error A panicking request handler currently escapes the per-request goroutine in handleAsync and terminates the entire server process, taking every session down with it. Handlers are user code operating on attacker-controlled input, so a single malformed request can crash the server. Recover panics in the handler goroutine and reply with an internal error (code -32603) instead, matching the isolation behavior of the other official SDKs. A new ErrPanic sentinel distinguishes recovered panics from ordinary handler errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A panicking request handler currently escapes the per-request goroutine in
handleAsyncand terminates the entire server process, taking every session down with it. Handlers are user code operating on attacker-controlled input (e.g.tools/callarguments), so a single malformed request can crash the server remotely.This change recovers panics in the handler goroutine and replies with an internal error (
-32603) instead, matching the isolation behavior of the other official SDKs:ErrPanicsentinel distinguishes recovered panics from ordinary handler errors.processResult, so the client receives code-32603and the connection stays usable.Tests
TestServerToolPanicinmcp/error_test.go: a panicking tool handler yields a-32603error to the client, and a subsequenttools/callon the same connection succeeds.