Repository navigation
[Server] Stop a retried resources/read from leaving out its caching hints - #667
Merged
chr-hertel merged 1 commit intoNov 5, 2026
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
November 5, 2026 00:31
chr-hertel
added
breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of a retried
resources/readleft outttlMsandcacheScope, so the TS SDK client refuses it withInvalid result for resources/read. The spec requires the hints on every complete read and forbids caching a retry, so it now always carriesttlMs: 0andcacheScope: private, also over hints its handler set.Spotted with #665 - its TS client test can cover
resources/readonce both are in.