fix(stdio): suppress BrokenResourceError in stdout_reader (#1960)#2723
Open
Epochex wants to merge 1 commit into
Open
fix(stdio): suppress BrokenResourceError in stdout_reader (#1960)#2723Epochex wants to merge 1 commit into
Epochex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1960.
stdio_client()can exit while the server is still writing to stdout. With the read stream unconsumed (0-sized memory stream),stdout_readercan be parked insideread_stream_writer.send(...). When the context manager closes the receive side during teardown, anyio raisesBrokenResourceError, which currently escapes the task group as anExceptionGroup.Changes:
(ClosedResourceError, BrokenResourceError)as a normal shutdown signal instdout_reader.stdout_readeris blocked insend()(read_stream.statistics().tasks_waiting_send > 0) before exiting the context.Tests:
uv run --frozen pytest tests/client/test_stdio.py::test_stdio_client_exits_cleanly_while_stdout_reader_is_blocked_in_senduv run --frozen ruff format src/mcp/client/stdio.py tests/client/test_stdio.pyuv run --frozen ruff check src/mcp/client/stdio.py tests/client/test_stdio.py