Repository navigation
fix(cli): handle missing Windows npx without crashing - #3687
Sak3th2004 wants to merge 1 commit into
Conversation
Catch FileNotFoundError when probing npx on Windows, add return annotations for CLI helpers, and cover the missing-binary path in unit tests. Fixes modelcontextprotocol#3673.
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3673. If a maintainer assigns you to #3673, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
On Windows, probing for
npxviasubprocess.runcan raiseFileNotFoundErrorwhen the executable is absent._get_npx_command()previously only caughtCalledProcessError, somcp devcould crash instead of returningNoneand printing the existing missing-npx guidance.This change:
(CalledProcessError, FileNotFoundError)in_get_npx_command()_get_npx_command,_import_server, and_check_server_object_check_server_objectto takeobjectinstead ofAnyFixes #3673
Test plan
test_get_npx_returns_none_when_windows_binary_missingtests/cli/test_utils.pyAI assistance: used Cursor to draft the patch and PR text; I own the change and can iterate on review feedback.