fix(publisher): omit repository when URL cannot be detected#1149
Open
JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(publisher): omit repository when URL cannot be detected#1149JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Return an empty string from detectRepoURL() when no repository can be determined, instead of a placeholder URL. This causes createServerJSON() to omit the repository field entirely, avoiding schema validation failures from empty or placeholder URI values on publish. Fixes modelcontextprotocol#613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
detectRepoURL()cannot determine the repository (no git remote, no package.json repository field), return an empty string instead of a placeholder URL (https://github.com/YOUR_USERNAME/YOUR_REPO). This causescreateServerJSON()to omit therepositoryfield entirely, preventing schema validation failures on publish.Fixes #613
Problem
mcp-publisher initgenerated arepositoryobject with a placeholder URL that fails theuriformat validation on publish. 88 published servers in the official registry had this issue.Change
cmd/publisher/commands/init.go:detectRepoURL()returns""instead of placeholder when no repo is foundcreateServerJSON()(if repoURL != "" && repoSource != "") already handles this correctly — it omits the repository when URL is emptyTest plan
go build ./cmd/publisher/...compilesgo test ./cmd/publisher/commands/...passesmcp-publisher initin a directory without git remote or package.json repo — verify norepositoryfield in generated server.jsonmcp-publisher initin a git repo — verifyrepositoryis populated correctlyAI Disclosure
AI assistance (Claude) was used for issue research. The implementation was written and reviewed by the author.