Repository navigation
Catch nested server.json publish PRs and clarify publishing guidance - #1702
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid publishing attempts such as #1698 add
server.jsonunder a namespace path (io.quickbrew/mcp-server/server.json), which the existing auto-close workflow misses. Match**/server.jsonin both detection and closure so these paths are handled consistently, and update the closure message to explain the broader coverage.Clarify in README.md and CLAUDE.md that adding server files anywhere in this repository does not publish a server, even if a PR is merged. Direct publishers to
mcp-publisherin their own project.Add
AGENTS.mdas a symlink toCLAUDE.mdso agents using either filename read the same guidance without duplicating it.Update the pinned golangci-lint from v2.13.1 to v2.14.0 after CI using Go 1.27.2 failed to decode Go export data with the old linter. Lint, validation, and build passed with the updated linter. The subsequent vulnerability scan reported five findings in golang.org/x/net v0.59.0, so update it to the reported fixed version, v0.60.0, and refresh module checksums.
The existing trusted-contributor exemption and requirement that every changed file match remain in place. The broader rule intentionally also covers PRs consisting only of
server.jsonfixtures or examples from untrusted contributors; these can require maintainer intervention.Validation: 12 behavioral cases passed for each matcher, including the path from #1698, nested paths, root paths, mixed code/documentation changes, and non-matching filenames. Confirmed both matchers agree, both workflows parse as YAML, all embedded Bash scripts pass
bash -n, andgit diff --checkpasses.