fix: treat empty cacheScope as omitted - #1241
Open
ismail-rt wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
T-test
ismail-rt
changed the title
ismail-rt
force-pushed
the
tolerate-empty-cache-scope
branch
from
September 2, 2026 20:17
a4bed59 to
2ccc934
Compare
An empty cacheScope string is invalid under SEP-2549, but some hosted servers emit it. Rejecting the whole tools/list payload currently drops every tool from an otherwise valid response.
ismail-rt
force-pushed
the
tolerate-empty-cache-scope
branch
from
September 2, 2026 20:17
2ccc934 to
611dc34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1242.
Motivation and Context
SEP-2549 allows
cacheScopeto be"public","private", or omitted. Some hosted servers send"". The deserializer treats that as an unknown variant, sotools/list(andresources/read) fail to parse as the typed result.ServerResultis untagged. WhenListToolsResultrejects the payload, it falls through toCustomResult. The tools are on the wire and then disappear.Negative
ttlMsis already clamped to0. EmptycacheScopenow maps toNone. Unknown or whitespace values still error.How Has This Been Tested?
empty_cache_scope_is_treated_as_omittedincrates/rmcp/tests/test_cache_hints.rsunknown_cache_scope_still_errors("shared"and" "still fail)empty_cache_scope_list_tools_result_does_not_fall_throughincrates/rmcp/tests/test_deserialization.rsBreaking Changes
None. Empty
cacheScopepreviously failed to decode. It is now treated as omitted.Types of changes
Checklist