Repository navigation
Conversation
Contributor
|
@bolinfest is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
aphonpra-oai
marked this pull request as ready for review
October 15, 2026 17:11
|
Quick routing check: the automated reviewer is no longer on the current Rust SDK roster, and the four fork workflows are still waiting for first-time-contributor approval. Could a current maintainer reroute the review and approve the workflows if appropriate? The diff is 25 additions and one deletion, with six focused regression tests and no public API change. |
DaleSeo
reviewed
Oct 22, 2026
Contributor
Author
|
Thanks for the review @DaleSeo, addressed the comments. |
DaleSeo
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interrupted SSE stream reconnects with GET. When GET is unsupported (405), or authorization is still required (401/403), retrying the same request can continue indefinitely under the default retry policy. A global retry limit would also abandon recoverable responses after temporary failures.
Treat
ServerDoesNotSupportSse,AuthRequired, andInsufficientScopeas terminal for the affected reconnect stream. Yield the error once and stop reconnecting that stream; all other errors retain their configured retry policy. Any authentication refresh handled within the HTTP client happens before this classification sees its returned error.An interrupted POST request fails without replaying the operation. Later POST requests remain available; a stopped listener is not automatically reauthorized or restarted. This does not add automatic sign-in, new user-facing error messages, or an endpoint-wide unsupported flag. The classification is internal and does not change the public retry-policy API.
Reproduce using the included scripted transport:
Validation uses mocked HTTP clients around the real transport/service, not a deployed client: