Repository navigation
Conversation
1e43479 to
af53c65
Compare
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: Verified MCP server implementation for consistency with current SDK patterns.
af53c65 to
4910146
Compare
4910146 to
8fa1014
Compare
8fa1014 to
c70bca7
Compare
|
Thank you for this pull request, and apologies for the long wait for a response. Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form. This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see This is part of the backlog triage in #4875. |
Description
Fixes a Windows-specific test teardown failure in
mcp-server-gittests due to:git.Repoinstance, causingshutil.rmtreeto raisePermissionError: [WinError 32].shutil.rmtreeto raisePermissionError: [WinError 5].Server Details
Motivation and Context
Developers attempting to run python tests for
mcp-server-giton Windows usinguv run pytestencounter permission errors during the teardown of thetest_repositoryfixture, which halts test suite completion. This fix resolves these issues, enabling local developer testing on Windows.How Has This Been Tested?
We verified the fix by running the test suite locally on a Windows host using:
All 41 tests passed successfully with no errors (previously, 35 out of 41 tests failed during the teardown phase with PermissionError).
Breaking Changes
Types of changes
Checklist
Additional context
onerrorpattern withshutil.rmtreeto clear the read-only attribute viaos.chmodprior to file removal.test_repo.close()to release all locks and file handles held by GitPython on the repo directory.