Skip to content

fix(git): set raise_exceptions=False for server stability - #4230

Closed
simpleprogrammer2 wants to merge 3 commits into
modelcontextprotocol:mainfrom
simpleprogrammer2:fix/git-server-reliability
Closed

simpleprogrammer2 wants to merge 3 commits into
modelcontextprotocol:mainfrom
simpleprogrammer2:fix/git-server-reliability

Conversation

@simpleprogrammer2

Copy link
Copy Markdown

This PR resolves Issue #4213 where the mcp-server-git would crash upon receiving malformed JSON-RPC messages or encountering internal exceptions.

Technical Change

Changed raise_exceptions=True to False in the server.run() call. This ensures that the server remains resilient and returns standard JSON-RPC error responses instead of terminating the process, consistent with other reference servers.

@LuuOW LuuOW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical audit: Verified MCP server implementation for consistency with current SDK patterns.

@simpleprogrammer2
simpleprogrammer2 requested a review from LuuOW July 19, 2026 02:53
@cliffhall cliffhall added the closed-superseded-v2 Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875) label Oct 20, 2026
@cliffhall

Copy link
Copy Markdown
Member

Thank you for this pull request, and apologies for the long wait for a response.

Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). The code this PR changes has been replaced, and the behavior it addresses has either been fixed in v2 or no longer exists in the same form.

This is not a judgment on the change or on you; it's a consequence of the code it targets having been replaced. If the problem still happens on v2, please open a fresh issue with the version you're running and steps to reproduce. Note that this repository now accepts contributions as issues rather than pull requests from anyone but its maintainers; see CONTRIBUTING.md.

This is part of the backlog triage in #4875.

@cliffhall cliffhall closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-superseded-v2 Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants