fix(filesystem): reject existing move destinations#4531
Open
dev-willbird1936 wants to merge 1 commit into
Open
fix(filesystem): reject existing move destinations#4531dev-willbird1936 wants to merge 1 commit into
dev-willbird1936 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the filesystem server's
move_filehonor its documented no-overwrite contract. Existing destination files, directories, and symlinks now return a tool error instead of being replaced.Root cause
POSIX
fs.renamereplaces an existing destination. The previous implementation could therefore destroy destination data despite the tool description promising failure on conflicts.Testing
git diff --checkpassed.The repository baseline itself fails a default Prettier check for these two existing files; the same check fails on
origin/main. No unrelated formatter churn is included in this branch. Hosted CI and maintainer review remain pending.