fix(git): handle non-UTF-8 bytes in git_show#4532
Open
dev-willbird1936 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the Git server's
git_showrobust to valid commits whose patch contains bytes that are not valid UTF-8. Decode replacement bytes instead of failing the complete result withUnicodeDecodeError.Root cause
The Git server strictly decoded GitPython patch bytes as UTF-8. One invalid byte could discard the complete patch result, including otherwise useful commit metadata.
Testing
git_show_handles_non_utf8_diffassertion passed.uv run ruff checkpassed.uv run pyrightpassed.uv buildpassed.This is an ordinary correctness/robustness fix, not a security report. Hosted POSIX CI is recommended to remove the Windows-only fixture teardown noise. Maintainer review remains pending.