fix(git): strictly validate repo path, working tree, and git directory - #4723
Open
AbhiPra24 wants to merge 1 commit into
Open
fix(git): strictly validate repo path, working tree, and git directory#4723AbhiPra24 wants to merge 1 commit into
AbhiPra24 wants to merge 1 commit into
Conversation
…apes - Validate repo working directory and git directory against allowed repository - Ensure repository path containment prevents path traversal and symlink escapes - Add tests for prefix collision, nested symlink chains, and internal symlinks Fixes modelcontextprotocol#4550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens repository path validation in
mcp-server-gitto strictly prevent path traversal or symlink escapes outside the allowed repository root directory.repo.working_dirandrepo.git_diragainst the allowed repository path incall_toolto prevent escapes via worktrees, submodules, or symlinked git directories.Fixes #4550