fix(memory): guard against undefined observations in searchNodes - #4731
Open
CryoThrust wants to merge 1 commit into
Open
fix(memory): guard against undefined observations in searchNodes#4731CryoThrust wants to merge 1 commit into
CryoThrust wants to merge 1 commit into
Conversation
Entities loaded from JSONL files may have missing observations fields (e.g., from older data or malformed entries). Calling .some() on undefined throws TypeError: Cannot read properties of undefined. Use nullish coalescing to default to an empty array. Fixes modelcontextprotocol#1818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1818
Problem
search_nodesthrowsTypeError: Cannot read properties of undefined (reading 'some')when an entity in the JSONL file has a missingobservationsfield. This can happen with older data files or malformed entries.Fix
Use nullish coalescing (
??) to defaultobservationsto an empty array before calling.some():Tests
All 50 existing tests pass. The fix is backward-compatible — entities with properly defined
observationsarrays are unaffected.