Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

- name: Create or update Version Packages PR
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1
uses: changesets/action@198f833dd7d863100ea6e28967bc9a9fdefadb0a # v1
env:
GITHUB_TOKEN: ${{ github.token }}

Expand Down Expand Up @@ -74,7 +74,7 @@
run: npm install -g npm@11.5.1

- name: Publish to npm
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1
uses: changesets/action@198f833dd7d863100ea6e28967bc9a9fdefadb0a # v1

Check failure on line 77 in .github/workflows/release.yml

View check run for this annotation

Claude / Claude Code Review

changesets/action bumped from v1 to v2 SHA without migrating the v2-renamed inputs/outputs: the `publish` input (line 79) is now `publish-script`, and the `hasChangesets` output consumed at lines 18/46 is now `has-changesets`, so the workflow still uses [

changesets/action bumped from v1 to v2 SHA without migrating the v2-renamed inputs/outputs: the `publish` input (line 79) is now `publish-script`, and the `hasChangesets` output consumed at lines 18/46 is now `has-changesets`, so the workflow still uses [additional confirmed claim at this location: [quality] nit: stale version comment — both bumped `uses:` lines keep `# v1` while the new SHA targets changesets/action v2.1.0 sweep:`changesets/action@ 198f833dd7d863100ea6e28967bc9a9fdefadb0a # v
Comment on lines 74 to +77

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 changesets/action bumped from v1 to v2 SHA without migrating the v2-renamed inputs/outputs: the publish input (line 79) is now publish-script, and the hasChangesets output consumed at lines 18/46 is now has-changesets, so the workflow still uses [additional confirmed claim at this location: [quality] nit: stale version comment — both bumped uses: lines keep # v1 while the new SHA targets changesets/action v2.1.0 sweep:changesets/action@ 198f833dd7d863100ea6e28967bc9a9fdefadb0a # v1]

Extended reasoning...

After merge, on the next push to main the version job's steps.changesets.outputs.hasChangesets is empty (v2 only emits kebab-case has-changesets), so the publish job's condition needs.version.outputs.hasChangesets == 'false' never evaluates true and the Publish job is permanently skipped; even when it would run, v2 ignores the unknown publish input (renamed to publish-script), so pnpm run ci:publish is never executed. Net effect: npm releases silently stop shipping. Fix in one sweep by updating the workflow to the v2 names (per the changesets/action v2.0.0 changelog quoted in the PR: publish -> publish-script, outputs kebab-cased).

Verification: normal — the diff bumps changesets/action to the v2.1.0 SHA (uses: changesets/action@ 198f833dd7d863100ea6e28967bc9a9fdefadb0a at .github/workflows/release.yml:39 and :77) while the workflow keeps every v1-era name that v2.0.0 renamed or removed: line 79 still passes publish: pnpm run ci:publish (v2 renamed this input to publish-script; unknown inputs are silently ignored by the Actions runn

with:
publish: pnpm run ci:publish
env:
Expand Down
Loading