performance(ring para): change sdpa backend to flash attention - #267
Open
JasonHe-WQ wants to merge 1 commit into
Open
performance(ring para): change sdpa backend to flash attention#267JasonHe-WQ wants to merge 1 commit into
JasonHe-WQ wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the sdpa attention backend with ring sp, this pr replaces efficient backend with flash backend to accelerate.
Related Issue
#266
Test Env
sdpaA red fox sitting beside a mountain lake at sunrise, highly detailedblurry, low qualityPrecision
From tables above, we can conclude that comparing to efficient CP2, flash ring CP2 achieves comparable precision to ulysses SP2.
Throughput