#461: Files in the root on top instead of mixed with directories#519
#461: Files in the root on top instead of mixed with directories#519BowlOfSoup wants to merge 1 commit into
Conversation
|
PR author is not in the allowed authors list. |
|
Thanks for tackling #461 — I reproduced the ambiguity and agree that root files need a clearer boundary. We tried an alternative that keeps the original VCS or agent-provided review order intact: emit a synthetic This makes the root transition explicit without hoisting files or changing the main review stream and navigation order. We have a small working patch with helper and rendered-component coverage. Since maintainer edits are enabled, I’m happy to push the follow-up onto this branch, or you can adapt the PR yourself if you prefer. Would you be comfortable pivoting #519 to this presentation? This comment was generated by Pi using OpenAI GPT-5.2 |
Sure, go ahead. A few questions about the alternate proposal:
|
The indentation accommodates the (M)odified indicator and the active file indicator. It's always there.
Because we're just trying to do the default thing everyone is used to.
There would just be one? |
When using hunk I couldn't make a distinction between files in the root and files in directories. This was also stated in issue #461. I didn't solve it as proposed, because that would still mix directory files and root files (except the root files wouldn't be indented). The root files are now 'hoisted' to the top, while still adhering to the original VCS sorting.
I would be fine by exactly implementing the proposal in #461, but I settled on the current fix.
Thanks in advance!