Conversation
Pick the newest visible matching version per project directly in Postgres instead of fetching every candidate version, loading all of them through `DBVersion::get_many`, filtering visibility in Rust and loading the winners a second time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pick the newest matching listed version per hash directly in Postgres
instead of loading every version of every project through
`DBVersion::get_many` and filtering in Rust. Visibility is still checked
on the picked version only, so a hidden or withheld newest match still
returns nothing. `version_file/{hash}/update` shares the same query, and
`update_individual` now uses the read-only pool.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`get_files_missing_attribution` now takes each version's project and first finds the projects that aren't exempt and have unresolved attribution groups. When there are none, which is the case for every mod and every grandfathered project, the file lookup doesn't run at all, instead of reading every file of every version passed in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CROSS JOIN LATERALquery. Massively reduces the amount of queries + Redis commands + data loaded.project_attribution_groupsattribution checks. So file-level checks are almost always never necessary.Fixes DEV-1473