Remove goreleaser Pro key from Atlas CLI Kubernetes plugin#188
Open
Remove goreleaser Pro key from Atlas CLI Kubernetes plugin#188
Conversation
The project uses no Pro-only features, so there is no reason to carry the Pro license key. Replace the Pro binary download with a pinned community release, remove the GORELEASER_KEY export from the packaging script, and update the goreleaser schema reference accordingly. CLOUDP-401819
josvazg
reviewed
May 4, 2026
Collaborator
josvazg
left a comment
josvazg
left a comment
There was a problem hiding this comment.
LGTM, waiting for CI to agree
Great to see we can go back to the community version here!
rhel90-small cannot reach GitHub's release CDN directly, so a hardcoded GitHub URL fails at setup. Keep the same expansion variable pattern as the original goreleaser_pro_tar_gz, renamed to goreleaser_tar_gz. A project admin needs to add goreleaser_tar_gz in Evergreen project settings pointing to the community binary at the same internal host. CLOUDP-401819
josvazg
approved these changes
May 5, 2026
Collaborator
Author
|
triggering a patch before merging |
go install github.com/google/go-licenses@latest resolves to v1.6.0, which fails on stdlib packages with Go 1.21+. The parent atlas-cli project already uses the go tool directive pattern (v2.0.1) which handles this correctly. Add go-licenses/v2 as a tool directive in go.mod and switch generate-notices.sh to use go tool go-licenses.
Collaborator
|
@blva Good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The project uses goreleaser Pro (via a license key managed in Evergreen) but uses no Pro-only features. This change switches to the community edition.
goreleaser_pro_tar_gzPro binary download with a pinned community release (v2.15.4) in the Evergreeninstall goreleaserfunction.GORELEASER_KEYexport frombuild/package/package.sh.goreleaser_keyfrominclude_expansions_in_envin the Evergreenpackagefunction.schema-pro.jsontoschema.json.Closes CLOUDP-401819.
Test plan
test-traceEvergreen task (test_mode: true, runs--snapshot) to confirm goreleaser installs and packages successfully without the Pro key.grep -r GORELEASER_KEY .andgrep -r goreleaser_pro .return no results.