Repository navigation
[Spec Resync] 06-03-2026 - #2841
Merged
Merged
Conversation
- Fix apply_patches to glob *.patch files only (not directories) so the permanent/ subdirectory no longer breaks git apply - Include permanent/*.patch in the patch list - Remove incorrect -R flag; all patches are forward patches - Add PYTHON-5809.patch to revert afterClusterTime readConcern changes in transaction tests that PyMongo does not yet implement - Revert load_balancer, server_selection_logging, and transaction test changes from upstream; these are handled by existing permanent patches and the new PYTHON-5809 patch respectively
blink1073
marked this pull request as draft
June 3, 2026 12:38
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Newer MongoDB executes $where in WASM and returns Interrupted (11601) instead of MaxTimeMSExpired (50) when max_time_ms kills the execution. PyMongo only appends the configured timeout details for code 50, so the assertIn check was failing. Make the assertion conditional on the error being an ExecutionTimeout (code 50).
blink1073
marked this pull request as ready for review
June 3, 2026 16:14
blink1073
reviewed
Jun 3, 2026
| try: | ||
| # Avoid shell=True by passing arguments as a list. | ||
| # Note: glob expansion doesn't work in shell=False, so we use a list of files. | ||
| patches = [str(p) for p in pathlib.Path("./.evergreen/spec-patch/").glob("*")] |
Member
There was a problem hiding this comment.
This was a bug fix. We weren't properly applying patches from the permanent folder.
Contributor
There was a problem hiding this comment.
my bad 🤦 thanks for catching that!
sleepyStick
approved these changes
Jun 3, 2026
sleepyStick
left a comment
sleepyStick
left a comment
Contributor
There was a problem hiding this comment.
lgtm pending passing evergreen tests -- thanks!
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira tickets: https://jira.mongodb.org/issues/?jql=labels%20%3D%20automated-sync%20AND%20status%20!%3D%20Closed
The following specs were changed:
-connection_monitoring
-load_balancer
-server_selection_logging
-transactions
-transactions-convenient-api
The following spec syncs encountered errors:
-applying patches
The following directories are in the specification repository and not in our test directory:
-causal_consistency
-open_telemetry