[NoahStapp]

…ol_is_not_cleared

PYTHON-5875

Changes in this PR

test_connection_pool_is_not_cleared uses setParameter, which only applies to the server executed on. This change calls setParameter on each mongos in a sharded cluster for the test, falling back to the current behavior for other topologies.

Test Plan

Test change.

Checklist

Checklist for Author

• [ ] Did you update the changelog (if necessary)?
• Is there test coverage?
• [ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

• Does the title of the PR reference a JIRA Ticket?
• Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
• Is all relevant documentation (README or docstring) updated?

[Copilot]

Pull request overview

This PR updates the pool-backpressure test test_connection_pool_is_not_cleared to apply setParameter to each mongos when running against a sharded cluster, while preserving the existing behavior for non-sharded topologies.

Changes:

• Detect sharded cluster topology via *_client_context.mongoses and create per-mongos admin clients.
• Run the ingress rate limiter setParameter commands on each mongos (sync + async).
• Disable the rate limiter in teardown across all targeted mongos instances (sync + async).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
test/test_discovery_and_monitoring.py	Run ingress rate limiter setParameter on all mongos instances in sharded clusters for the sync test.
test/asynchronous/test_discovery_and_monitoring.py	Mirror the same multi-mongos setParameter behavior for the async test.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[aclark4life]

Looks like the 🤖 may be on to something with:

The async teardown cleanup is registered after the setParameter calls. If enabling/configuring the rate limiter raises, it can remain enabled and impact later tests. Register the cleanup before issuing setParameter so it still runs on early failures.

The IP formatting issue could be fixed too, but then we should probably fix other uses of that syntax elsewhere in the code. Maybe a new ticket for that (if you think the suggested formatting is better) and merge this one with the IP formatting as-is.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[aclark4life]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

How did you get copilot to give up on IP formatting? Wondering if your comment or resolving does it.

Test failures unrelated right?

[NoahStapp]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

How did you get copilot to give up on IP formatting? Wondering if your comment or resolving does it.

Test failures unrelated right?

Yes, resolving does it. Test failures are all QE preview changes that will be resolved by PYTHON-5912.