Skip to content

PYTHON-5913 - Remove synchro converted_tests and associated CONTRIBUT… - #2908

Merged
NoahStapp merged 2 commits into
mongodb:masterfrom
NoahStapp:PYTHON-5913
Jul 1, 2026
Merged

NoahStapp merged 2 commits into
mongodb:masterfrom
NoahStapp:PYTHON-5913

Conversation

@NoahStapp

Copy link
Copy Markdown
Contributor

…ING.md section

PYTHON-5913

Changes in this PR

See ticket.

Test Plan

N/A.

Checklist

Checklist for Author

  • [ ] Did you update the changelog (if necessary)?
  • [ ] Is there test coverage?
  • [ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes now-obsolete test-conversion scaffolding from the repo by eliminating the dedicated convert_test_to_async.py helper and simplifying synchro.py so it no longer relies on a hardcoded allowlist of “converted” async tests.

Changes:

  • Remove the converted_tests allowlist from tools/synchro.py and generate the list of converted test outputs directly from the async test sources.
  • Delete tools/convert_test_to_async.py.
  • Remove documentation references/instructions for the deleted script from CONTRIBUTING.md and AGENTS.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/synchro.py Drops the hardcoded converted-tests list and derives generated test outputs directly from filtered async test inputs.
tools/convert_test_to_async.py Deleted obsolete script for generating async test stubs.
CONTRIBUTING.md Removes section documenting the deleted async test conversion script.
AGENTS.md Removes references and workflow steps involving the deleted conversion script.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

sleepyStick
sleepyStick previously approved these changes Jul 1, 2026
@NoahStapp
NoahStapp merged commit ed81f02 into mongodb:master Jul 1, 2026
81 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants