Repository navigation
PYTHON-5913 - Remove synchro converted_tests and associated CONTRIBUT… - #2908
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes now-obsolete test-conversion scaffolding from the repo by eliminating the dedicated convert_test_to_async.py helper and simplifying synchro.py so it no longer relies on a hardcoded allowlist of “converted” async tests.
Changes:
- Remove the
converted_testsallowlist fromtools/synchro.pyand generate the list of converted test outputs directly from the async test sources. - Delete
tools/convert_test_to_async.py. - Remove documentation references/instructions for the deleted script from
CONTRIBUTING.mdandAGENTS.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/synchro.py | Drops the hardcoded converted-tests list and derives generated test outputs directly from filtered async test inputs. |
| tools/convert_test_to_async.py | Deleted obsolete script for generating async test stubs. |
| CONTRIBUTING.md | Removes section documenting the deleted async test conversion script. |
| AGENTS.md | Removes references and workflow steps involving the deleted conversion script. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sleepyStick
previously approved these changes
Jul 1, 2026
sleepyStick
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ING.md section
PYTHON-5913
Changes in this PR
See ticket.
Test Plan
N/A.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is there test coverage?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer