Repository navigation
PYTHON-5920 - Use mock instead of patching for test_network_layer.py - #2920
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the synchronous unit tests for pymongo.network_layer to avoid patching module-level functions (receive_data) and instead mock socket reads on a per-connection basis, reducing the chance of cross-test/thread interference.
Changes:
- Removed
patch-based mocking ofnetwork_layer.receive_datainTestReceiveMessage. - Added
_mock_recv_intohelper to scope mocked reads to a specific connection’srecv_into. - Updated affected
receive_messagetests to use_mock_recv_intowith deterministic byte chunks.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5920
Changes in this PR
Replace the patching in
test_network_layer.pywith a scoped mock to avoid race conditions.Test Plan
Test changes.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer