PYTHON-5727 Add tests for __main__ blocks#2936
Draft
aclark4life wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end test coverage for the pymongo.uri_parser module’s __main__ block by executing it as a real module in a subprocess, ensuring both the success path (pretty-printed parsed result) and the handled error path (InvalidURI) are exercised.
Changes:
- Add subprocess-based tests that run
python -m pymongo.uri_parser <uri>and assert expected stdout content. - Cover both valid URI parsing output and invalid URI error message output while confirming exit code
0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5727
Changes in this PR
Adds test coverage for the previously untested
__main__block inpymongo/uri_parser.py.A new
TestMainBlockclass intest/test_uri_parser.pylaunches the module as a script viasubprocess(python -m pymongo.uri_parser <uri>) and covers both branches:Both cases assert a clean (
0) exit code.Note:
pymongo/daemon.py— the other module named in the ticket — already hasTestMainBlockcoverage on master. A repo-wide search confirmed these are the only two__main__blocks inpymongo/,bson/, andgridfs/.Test Plan
python -m pytest test/test_uri_parser.py::TestMainBlock test/test_daemon.py::TestMainBlock -vpasses.__main__block end-to-end through a real subprocess, socoverage.pysubprocess measurement will capture it.Checklist
Checklist for Author
Checklist for Reviewer