RUBY-3831 Skip OpenTelemetry command spans - backport#3042
Merged
comandeo-mongo merged 1 commit intomongodb:2.23-stablefrom May 8, 2026
Merged
RUBY-3831 Skip OpenTelemetry command spans - backport#3042comandeo-mongo merged 1 commit intomongodb:2.23-stablefrom
comandeo-mongo merged 1 commit intomongodb:2.23-stablefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Backports RUBY-3831 to the 2.23.x line by preventing OpenTelemetry command spans from being created for commands that may contain credentials (and for hello/legacy hello), avoiding potential sensitive data leakage via span attributes like db.query.text.
Changes:
- Update the OpenTelemetry
CommandTracerto short-circuit tracing for sensitive/auth commands and forhello/ismaster/isMaster. - Add specs asserting no span/context is created for skipped commands while still yielding and returning the block result.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/mongo/tracing/open_telemetry/command_tracer.rb |
Adds sensitive/hello skip logic so no command span is created for these commands. |
spec/mongo/tracing/open_telemetry/command_tracer_spec.rb |
Adds coverage to ensure skipped commands do not create spans/contexts but still execute the command block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamis
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is backport of #3038 to 2.23.x