RUBY-3797 Migrate away from set-temp-creds.sh#3065
Draft
comandeo-mongo wants to merge 2 commits into
Draft
Conversation
The legacy csfle/set-temp-creds.sh script is deprecated in drivers-evergreen-tools (DRIVERS-3433). The main run-tests.sh path already moved to setup-secrets.sh under RUBY-3886, and setup_secrets.py now produces the same CSFLE_AWS_TEMP_* credentials. The only remaining consumer was run-tests-serverless.sh, which is dead code: serverless testing was removed in RUBY-3652 and no Evergreen task references the script. Delete it, and fix the now-stale spec_config.rb comments that still pointed at set-temp-creds.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate the Ruby driver off the deprecated
set-temp-creds.shscript fromdrivers-evergreen-tools, in preparation for its removal (DRIVERS-3433).
Context
The legacy
csfle/set-temp-creds.shis deprecated upstream and emits awarning pointing at
setup-secrets.sh. Most of the migration alreadyhappened:
run-tests.shmoved tosetup-secrets.shunder RUBY-3886 (RUBY-3886 Migrate FLE/CSFLE test secrets to AWS Secrets Manager #3048).setup_secrets.pynow produces the sameCSFLE_AWS_TEMP_*credentials(AWS temp key/secret/session token) plus Azure/GCP access tokens.
The only remaining consumer of
set-temp-creds.shwasrun-tests-serverless.sh. That script is dead code: serverless testing wasremoved in RUBY-3652 (#2942) and no Evergreen task references it
(
config.ymland the ERB templates have no serverless tasks).Changes
.evergreen/run-tests-serverless.sh(orphaned; lastset-temp-creds.shconsumer).spec/support/spec_config.rbthat stillreferenced
set-temp-creds.sh; theCSFLE_AWS_TEMP_*env vars theydocument are now produced by
setup-secrets.sh. The readers themselvesare unchanged and still used by the migrated
run-tests.shFLE path.After this change there are no remaining references to
set-temp-creds.shin the repository.
Test plan
CI/shell-only change. No runtime Ruby code is touched and no spec exercises
the deleted serverless script; the
spec_config.rbedit is comment-only.bundle exec rubocop spec/support/spec_config.rb— no offensesgit grep set-temp-creds— no references remainJira
https://jira.mongodb.org/browse/RUBY-3797