build(deps): bump the cargo group with 2 updates - #3019
Conversation
Bumps the cargo group with 2 updates: [rubato](https://github.com/HEnquist/rubato) and [str0m](https://github.com/algesten/str0m). Updates `rubato` from 4.0.0 to 5.0.0 - [Release notes](https://github.com/HEnquist/rubato/releases) - [Commits](HEnquist/rubato@v4.0.0...v5.0.0) Updates `str0m` from 0.22.0 to 0.23.0 - [Changelog](https://github.com/algesten/str0m/blob/main/CHANGELOG.md) - [Commits](algesten/str0m@0.22.0...0.23.0) --- updated-dependencies: - dependency-name: rubato dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: cargo - dependency-name: str0m dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 286593297b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| moq-net = { workspace = true } | ||
| reqwest = { version = "0.13", default-features = false, features = ["rustls"] } | ||
| str0m = "0.22" | ||
| str0m = "0.23" |
There was a problem hiding this comment.
Keep the str0m bump out of a patch-compatible release
Because moq-rtc publicly re-exports str0m and exposes its error types through Error::Rtc and Error::RtcInput, moving from 0.22 to the semver-incompatible 0.23 changes public type identity. A downstream crate that uses str0m 0.22 types alongside moq-rtc will get type mismatches after an otherwise compatible moq-rtc update. Keep 0.22 here or land this as an explicitly breaking release rather than the dependency-only patch release this commit currently produces.
AGENTS.md reference: AGENTS.md:L167-L169
Useful? React with 👍 / 👎.
| # fft_resampler feature and its RustFFT/realfft dependencies. | ||
| rand = "0.10" | ||
| rubato = { version = "4.0", default-features = false } | ||
| rubato = { version = "5.0", default-features = false } |
There was a problem hiding this comment.
Keep playback on a single rubato version
When the playback feature is enabled, fixed-resample 0.12.1 still depends on rubato 4.0.0, while this direct dependency now selects 5.0.0; the updated lockfile consequently contains both rubato versions and both audioadapter stacks. This defeats the manifest's stated intent that fixed-resample wrap the same resampler already used by the crate and adds duplicate compile and binary cost for playback users. Either retain rubato 4 or update fixed-resample to a release using rubato 5 in the same change.
Useful? React with 👍 / 👎.
Bumps the cargo group with 2 updates: rubato and str0m.
Updates
rubatofrom 4.0.0 to 5.0.0Release notes
Sourced from rubato's releases.
Commits
6b72d0fMerge pull request #139 from HEnquist/next5ee15e98Fix the process_all_into_buffer doctest without default features1fbcf3dSimplify and tidy up the examples3c3c254Process the last frames in the ramp example8f85c2dRead whole samples in the examples3249382Address review comments1116c1aUpdate the examples section of the READMEed77619Parse example arguments with clap4406cf0Drop two redundant examples03950dcFix clippy warningsUpdates
str0mfrom 0.22.0 to 0.23.0Changelog
Sourced from str0m's changelog.
Commits
67820c50.23.08855f4eFix RRTR originator SSRC and changelog0793ea7Respond to RRTR with DLRR (#1022)23627caAdd DirectApi::send_pli_feedback (#1025)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions