Skip to content

Prepare release v1.0.0 - #57

Open
henri-hulski wants to merge 10 commits into
masterfrom
prep_1.0.0
Open

henri-hulski wants to merge 10 commits into
masterfrom
prep_1.0.0

Conversation

@henri-hulski

Copy link
Copy Markdown
Member

@Daverball Can you take a look?

@coveralls

coveralls commented Sep 22, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 100.0% (+5.2%) from 94.847% — prep_1.0.0 into master

@Daverball Daverball left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the pyright failures on the CI due to the missing sphinx dependency in that tox environment. mypy only seems to succeed because the mypy configuration currently still ignores errors in dectate.sphinxext, so it's not in sync with the pyright config that no longer excludes that module.

Comment thread pyproject.toml Outdated
Comment on lines 86 to 88
[[tool.mypy.overrides]]
module = "dectate.sphinxext.*"
ignore_errors = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be inconsistent with the pyright config, but pyright also currently fails to type check. I assume it's missing the sphinx dependency in that specific tox environment.

@henri-hulski
henri-hulski force-pushed the prep_1.0.0 branch 2 times, most recently from 2a78f96 to f84739c Compare September 22, 2026 21:24
@henri-hulski

Copy link
Copy Markdown
Member Author

I fixed also the scenarios folder. I was still using the ols API before dectate 0.12.
Also removed now sphinxext ignore from mypy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants