Prepare release v1.0.0 - #57
Open
henri-hulski wants to merge 10 commits into
Open
henri-hulski wants to merge 10 commits into
henri-hulski wants to merge 10 commits into
Conversation
henri-hulski
force-pushed
the
prep_1.0.0
branch
from
September 22, 2026 17:33
051bb18 to
5310985
Compare
Daverball
approved these changes
Sep 22, 2026
Daverball
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me apart from the pyright failures on the CI due to the missing sphinx dependency in that tox environment. mypy only seems to succeed because the mypy configuration currently still ignores errors in dectate.sphinxext, so it's not in sync with the pyright config that no longer excludes that module.
Comment on lines
86
to
88
| [[tool.mypy.overrides]] | ||
| module = "dectate.sphinxext.*" | ||
| ignore_errors = true |
Contributor
There was a problem hiding this comment.
This seems to be inconsistent with the pyright config, but pyright also currently fails to type check. I assume it's missing the sphinx dependency in that specific tox environment.
henri-hulski
force-pushed
the
prep_1.0.0
branch
2 times, most recently
from
September 22, 2026 21:24
2a78f96 to
f84739c
Compare
henri-hulski
force-pushed
the
prep_1.0.0
branch
from
September 22, 2026 21:34
f84739c to
5dd5409
Compare
Member
Author
|
I fixed also the scenarios folder. I was still using the ols API before dectate 0.12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Daverball Can you take a look?