Update links to panda_moveit_config repository (ROS 1 → ROS 2)#1092
Open
evglouwe wants to merge 1 commit into
Open
Update links to panda_moveit_config repository (ROS 1 → ROS 2)#1092evglouwe wants to merge 1 commit into
evglouwe wants to merge 1 commit into
Conversation
130s
approved these changes
May 29, 2026
Contributor
130s
left a comment
130s
left a comment
There was a problem hiding this comment.
Just added a minor suggestion.
| Using STOMP with Your Robot | ||
| --------------------------- | ||
| **Note:** if you are following this demo using the ``panda_moveit_config`` from the `moveit/panda_moveit_config <https://github.com/moveit/panda_moveit_config>`_ repository, these steps are already done for you and you can directly launch the demo for testing STOMP in RViZ. | ||
| **Note:** if you are following this demo using the ``panda_moveit_config`` from the `moveit/moveit_resources <https://github.com/moveit/moveit_resources>`_ repository, these steps are already done for you and you can directly launch the demo for testing STOMP in RViZ. |
Contributor
There was a problem hiding this comment.
Suggested change
| **Note:** if you are following this demo using the ``panda_moveit_config`` from the `moveit/moveit_resources <https://github.com/moveit/moveit_resources>`_ repository, these steps are already done for you and you can directly launch the demo for testing STOMP in RViZ. | |
| **Note:** if you are following this demo using the ``panda_moveit_config`` from the `moveit/moveit_resources <https://github.com/moveit/moveit_resources/tree/ros2>`_ repository, these steps are already done for you and you can directly launch the demo for testing STOMP in RViZ. |
Not a strong opinion, but relying on the default branch of a repo may become fragile over time, so suggest to being a bit more specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some links in the tutorial referenced the ROS 1 version of panda_moveit_config. This updates the links to the correct ROS 2 repository.