Skip to content

Backport of Add explanation about IK plugins for servo (#474) to humble - #477

Open
mergify[bot] wants to merge 2 commits into
humblefrom
mergify/bp/humble/pr-474
Open

Backport of Add explanation about IK plugins for servo (#474) to humble#477
mergify[bot] wants to merge 2 commits into
humblefrom
mergify/bp/humble/pr-474

Conversation

@mergify

@mergify mergify Bot commented Jul 25, 2022

Copy link
Copy Markdown

This is an automatic backport of pull request #474 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add explanation to servo tutorial for how to configure an IK plugin for servo

* Make bio_ik suggestion

* fix formatting

Co-authored-by: AndyZe <andyz@utexas.edu>
(cherry picked from commit c7a0cb3)
@mergify mergify Bot added the distro_humble Humble branch label Jul 25, 2022
@tylerjw

tylerjw commented Jul 25, 2022

Copy link
Copy Markdown
Member

It looks like the version of MoveIt used by CI doesn't have this feature yet:

/home/runner/work/moveit2_tutorials/moveit2_tutorials/.work/upstream_ws/src/moveit_task_constructor/core/src/solvers/cartesian_path.cpp:62:47: error: ‘IKCostFn’ is not a member of ‘kinematics::KinematicsBase’
     62 |         p.declare<kinematics::KinematicsBase::IKCostFn>("kinematics_cost_fn", kinematics::KinematicsBase::IKCostFn(),
        |                                               ^~~~~~~~

This is because the version in the repos file does not point to a version of moveit that has this feature. Please try updating the repos file.

@vatanaksoytezer

Copy link
Copy Markdown
Contributor

We should probably remove the release jobs here. We don't need to use moveit2 in upstream.repos because we are already using the latest docker image.

@tylerjw

tylerjw commented Jul 26, 2022

Copy link
Copy Markdown
Member

We should probably remove the release jobs here. We don't need to use moveit2 in upstream.repos because we are already using the latest docker image.

Do you mind creating an issue to layout what you think our strategy should be with regard to the CI here depending on moveit docker images (and therefore how we should change the current system)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distro_humble Humble branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants