Conversation
Contributor
Author
|
Blocked on merge order. 15 checks pass. The one failure is Fix is already in #21016. This is the third PR blocked by the same test, so merging #21016 unblocks all of them. |
vpomerleau
requested changes
Aug 12, 2026
| dependant. | ||
| (webservices-infra). One entry provisions the topic, the push | ||
| subscription, and the Firestore webhook document. | ||
| <pre className="p-2">{`"${rpId}" = { |
Contributor
There was a problem hiding this comment.
issue (blocking): Missing # pragma: allowlist secret — without it detect-secrets flags the client id as a HexHighEntropyString and the operator's first commit fails pre-commit.
Suggested change
| <pre className="p-2">{`"${rpId}" = { | |
| <pre className="p-2">{`"${rpId}" = { # pragma: allowlist secret |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
fxa-legacytenant. Nobody updated the post-create steps on the admin panel.gcloud pubsub topics createby hand. That fails with a permission error now, and Terraform creates the topic anyway.OAUTH_CLIENT_IDSmap for legacy Amplitude events, which is deprecated.===, so any prod host other thanfxa-admin-panel.prod.mozaws.netsilently got the nonprod links.This pull request
gcloud pubsub topics createstep and theOAUTH_CLIENT_IDSstep fromPageRelyingParties/index.tsx.eventbroker_endpoint_subscription_configinwebservices-infrafxa-legacy/tf/{stage,prod}/locals.tf, and shows the entry shape. One entry gets you the topic, the push subscription, and the Firestore webhook document.getEventBrokerTfPath()next togetWafTfPath()inlib/utils.ts, using the samestartsWithhost check. That is the part that fixes the prod fall-through.utils.spec.ts, so the tests fail if the exact host match ever comes back. Drops theindex.test.tsxassertion for the gcloud command that no longer exists.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14345
Checklist
Put an
xin the boxes that applyHow to review (Optional)
PageRelyingParties/index.tsx, and the new helper inlib/utils.ts.lib/utils.ts, then the component, then the two test files.locals.tfpath and the entry shape against whatfxa-legacyactually expects. A wrong path sends operators to the wrong repo.Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
The panel wording follows the "Register Your Webhook" section of the public RP tutorial instead of new phrasing.
Both attributes in the map entry are optional.
resource_serverdefaults tofalse, and you leaveendpointout for a topic with no webhook.One caveat on local test results: six tests in
PageRelyingParties/index.test.tsxfail in my sandbox both before and after this change. The localreact-routeris v6 andRelyingPartyRowimportsNavLinkfrom it, which v6 does not export. That is an environment problem on my side, not something this PR touches. CI runs the full suite.