Bug 2062257 - sqlite: Use an in-memory database when delay_ping_lifetime_io=true - #3590
Draft
badboy wants to merge 1 commit into
Draft
Bug 2062257 - sqlite: Use an in-memory database when delay_ping_lifetime_io=true#3590badboy wants to merge 1 commit into
badboy wants to merge 1 commit into
Conversation
badboy
commented
Aug 17, 2026
| Ok(()) | ||
| } | ||
|
|
||
| fn persist_ping_lifetime_data_if_full(&self, tx: &mut Transaction) -> Result<()> { |
Member
Author
There was a problem hiding this comment.
Except for the actual INSERT INTO at the end this is exactly the same as the old implementation that was removed.
badboy
commented
Aug 17, 2026
badboy
commented
Aug 17, 2026
badboy
force-pushed
the
sqlite-use-an-in-memory-databa/wnzovuusnvwz
branch
from
August 17, 2026 16:01
f6c2260 to
5a3cac5
Compare
badboy
force-pushed
the
sqlite-use-an-in-memory-databa/wnzovuusnvwz
branch
from
August 18, 2026 10:57
5a3cac5 to
111153b
Compare
This restores `delay_ping_lifetime_io` behavior (not touching disk until `persist_ping_lifetime_data` is called, or in auto-mode when the counter/time is hitting the limit) The local benchmark shows it's twice as fast compared to current `main` (so compared to always hitting disk).
badboy
force-pushed
the
sqlite-use-an-in-memory-databa/wnzovuusnvwz
branch
from
August 18, 2026 11:02
111153b to
80d13ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores
delay_ping_lifetime_iobehavior (not touching disk untilpersist_ping_lifetime_datais called, or in auto-mode when the counter/time is hitting the limit)The local benchmark shows it's twice as fast compared to current
main(so compared to always hitting disk).Not yet ready for use. Should get some testing (and fixing at least one clippy lint).
Also some refactoring to not use the same string constant everywhere (and instead use a const for that)