reject over-long read counts in Mp4parseIo read impl - #457
Open
Chandan3456 wants to merge 1 commit into
Open
Chandan3456 wants to merge 1 commit into
Chandan3456 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Read impl for Mp4parseIo already refuses a buf longer than isize::MAX, but it hands the callback's return value straight back as Ok(rv as usize) once it's non-negative. a callback that reports more bytes than the buf.len() it was given breaks the Read contract that the count never exceeds the buffer, and the count then flows into Take/read_exact/read_to_end which trust it to stay in bounds (read_exact slices buf[n..], read_to_end grows by n). i noticed it reading the FFI shim right after the isize guard, where the second half of the same check was missing. this errors out when rv as usize > buf.len(), matching the existing guard, and adds a test with a callback that over-reports so the invalid count surfaces as an error instead of Ok.