reject oversized entry counts in stco/co64/stss/stsc/stts/stsz - #458
Open
Chandan3456 wants to merge 1 commit into
Open
Chandan3456 wants to merge 1 commit into
Chandan3456 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_ctts already rejects a ctts box whose declared entry count needs more bytes than the box holds, before it preallocates. reading through the sibling sample table parsers i noticed read_stco, read_co64, read_stss, read_stsc, read_stts and read_stsz skip that check -- each takes the u32 count straight off the wire and hands it to TryVec::with_capacity (or reserve) before reading a single entry, so a 16-byte stco claiming 0xffffffff offsets asks for a multi-gigabyte allocation for entries that cannot be present. i added the same count*entry_size against bytes_left guard read_ctts uses to each of them, behind one shared StblBadEntryCount status, plus a regression test. the check only fires when the declared count exceeds what the box can hold, so files with trailing padding are unaffected.